WHDLoad MantisBT - SWOS
View Issue Details
0005220SWOS[WHDLoad Installs Games] slavepublic2021-05-22 01:222024-05-19 19:10
Reporterpetarku 
Assigned ToJOTD 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
MachineA1200
CPU68020
CPUSpeed14
ChipSetAGA
GFXCardNone
ChipMem2 MB
FastMem4 MB
WorkbenchOS 3.0
KickROM39 - Kick 3.0
KickSoftNone
WHDLoad18.3
imported
Summary0005220: Import of saved tactic is not working
DescriptionFunctionality of saving and loading tactics is not working.
Steps to reproduce

start the game
click on edit tactics
choose user A for example
you will see the screen with the players and field , move cursor to the field and above one of the player and click and move couple of players up or down or whatever
go to save - you will get the notice that tactics is changed
save tactics under some name
All good so far.
then go again to edit tactics
choose user a tactic for example
click on import
go to load
choose tactics file that you saved

Expected result : positions of the players on the field is the same as you saved it
Actual result : all of the players are placed on right down positions on the field. in edit tactic name on that screen there is some garbage character in the name , to me looks like right offset from the file is not read or something but that is just my wild guess.
TagsNo tags attached.
Attached Filespng Screen Shot 2021-06-25 at 10.48.27.png (120,824) 2021-06-25 11:53
https://www.whdload.de/mantis/file_download.php?file_id=1232&type=bug
png

png Screen Shot 2021-06-25 at 10.50.30.png (126,019) 2021-06-25 11:53
https://www.whdload.de/mantis/file_download.php?file_id=1233&type=bug
png

png Screen Shot 2021-06-25 at 10.51.59.png (113,076) 2021-06-25 11:54
https://www.whdload.de/mantis/file_download.php?file_id=1234&type=bug
png

png Screen Shot 2021-06-25 at 10.55.13.png (31,727) 2021-06-25 11:55
https://www.whdload.de/mantis/file_download.php?file_id=1235&type=bug
png

Notes
(0010417)
JOTD   
2021-06-20 21:32   
(Last edited: 2021-06-20 21:33)
"save tactics under some name" .... after SAVE/EXIT I don't know what to do to save.

Also can you state the size of SWOS2 file (so I know for sure about the version you're using)

(0010434)
petarku   
2021-06-25 11:57   
you need to change player position and then click on save/exit and it will say that tactics has been changed. then you just proceed and it will give you option to save. I attached some png files there
is your problem that you dont see that tactics has been changed ?

swos2 file size is 167901. I attached png from workbench. It is 96/97 swos version.
(0011167)
JOTD   
2022-04-17 23:53   
(Last edited: 2022-04-20 23:06)
ok it's my 96-97 v2

yes, after moving players, SAVE/EXIT brings me back to main menu

So I don't have corruption, but I don't have saves either

(0012345)
Hungry Horace   
2023-01-22 23:33   
https://www.dropbox.com/s/l8db3x30hi3886t/SWOS%20Tactic%20Load%20Bug.mov?dl=0

Hi

This bug has been going on a long time on WHDload.

Took me a while to remember how, but you have to use the "LOAD" part of the import of tactics. Video link here ^^
(0012346)
Hungry Horace   
2023-01-22 23:36   
Please ignore me arguing with the mouse port around 0:30.

Towards the end you see I load the newly saved "Dom 1.TAC" both directly, and then using iMPORT/LOAD.

After the second one all players appear in the bottom right.
(0012355)
Playaveli   
2023-01-23 21:25   
I can confirm the tactic loading bug and recorded the easiest way to reproduce it. https://youtu.be/sPX4p-qZmno

I hope this can be solved! Thanks a lot for your efforts.

PMed on EAB, too!
(0012436)
Hungry Horace   
2023-02-07 00:16   
I haven’t looked into this properly but I notice other load routines are patched in the code via:

    PL_PS $51a5e,Load_Season
    PL_PS $51c1e,Load_Season ;Load Highlights!


Perhaps the tactics load routine isnt patched at all as it should be? There is no equivalent for the tactics load in the source code

This could be loading 0000 data, which might explain why the players all get squashed into the corner.

I am not very adept with disk routines but if JOTD is busy i will try and find time to check this possibility

Issue History
2021-05-22 01:22petarkuNew Issue
2021-05-22 10:39JOTDAssigned To => JOTD
2021-05-22 10:39JOTDStatusnew => acknowledged
2021-06-20 21:32JOTDNote Added: 0010417
2021-06-20 21:33JOTDNote Edited: 0010417bug_revision_view_page.php?bugnote_id=10417#r1422
2021-06-25 11:53petarkuFile Added: Screen Shot 2021-06-25 at 10.48.27.png
2021-06-25 11:53petarkuFile Added: Screen Shot 2021-06-25 at 10.50.30.png
2021-06-25 11:54petarkuFile Added: Screen Shot 2021-06-25 at 10.51.59.png
2021-06-25 11:55petarkuFile Added: Screen Shot 2021-06-25 at 10.55.13.png
2021-06-25 11:57petarkuNote Added: 0010434
2022-04-17 23:53JOTDNote Added: 0011167
2022-04-17 23:56JOTDNote Edited: 0011167bug_revision_view_page.php?bugnote_id=11167#r1483
2022-04-20 23:06JOTDNote Edited: 0011167bug_revision_view_page.php?bugnote_id=11167#r1484
2023-01-22 23:33Hungry HoraceNote Added: 0012345
2023-01-22 23:36Hungry HoraceNote Added: 0012346
2023-01-23 21:25PlayaveliNote Added: 0012355
2023-02-07 00:16Hungry HoraceNote Added: 0012436
2024-05-19 19:10JOTDStatusacknowledged => closed
2024-05-19 19:10JOTDResolutionopen => fixed